I'm tired boss. I'm tired of reviewing one, two, 3 thousand statement PRs because immoderate supplier was capable to "one changeable the full issue." Small PRs were ne'er asked for because they're easier to write, it's ever been for the use of the reviewer. AI is specified a boon to the industry, but it's becoming specified a liability for reviewers and maintainers. Maybe I'm conscionable an aged man yelling astatine the clouds, but please, extremity sending maine immense PRs.
I person heard connected aggregate occasions precocious the statement that "it won't activity without the full change" aliases "the codification will do thing if we don't put successful the full diff," well, yeah? Good? The constituent of mini PRs is not needfully to person small, individual, vanished products. It's to person small, digestable, reviewable, understandable pieces of work. I person nary information for this, truthful I will wildly speculate, that the clip it takes to afloat comprehend a portion of codification increases exponentially pinch the number of lines the codification covers. Taking up exponentially much of my clip because you wanted to vessel a afloat characteristic does not spark joy.
While we're astatine it, I don't request 50 statement comments. Sure, archive functions, springiness maine jsdoc, rustdoc, javadoc, each of that bully stuff. Absolutely do not springiness maine 5 lines of comments connected why a adaptable is named is_logged_in. If your adaptable is named well, 9 times retired of 10 I'll understand what it does. If your adaptable is not named good and you request a comment, sanction your adaptable better.
Finally, for you AI maximalists that opportunity "just usage AI to grok (not grok) it bro," you're wasting your tokens reingesting codification that was already made by an AI. "I usage a different exemplary for reviews though," okay, great, why did you put it up for a quality reappraisal astatine each then? Perhaps, you could person your precious AI abstracted it for america specified mortals and past reappraisal it aft we've had our turn?
Look -- AI is simply a awesome tool, it really helps things move faster and tin make codification better, but erstwhile React came retired we didn't judge larger PRs because "React is faster to constitute and easier to read," truthful why are we doing it now?
Addendum: are you conscionable making elephantine PRs truthful I springiness up halfway done and o.k. it? If so, good played. Well. Played.
English (US) · 
Indonesian (ID) ·